Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anndata_dask_array.ipynb: copy tweaks / improvements #19

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ryan-williams
Copy link

@ryan-williams ryan-williams commented Oct 30, 2024

anndata_dask_array.ipynb

  • Seed da.random/np.random ⟹ allow regenerating the notebook deterministically.
  • Copy tweaks: some typos, some more opinionated rephrasing, couple places described things that didn't match the cell outputs (e.g. claiming a slice result was eager when it wasn't), couple places I added a cell and some copy.
  • Kernel name: python3.bakpython3

Dockerfile / regenerate.sh

Regenerate notebook files deterministically (in Docker / using juq to clean notebooks / canonicalize outputs), e.g.:

./regenerate.sh anndata_dask_array

I've used it here on anndata_dask_array.ipynb, but not any other notebooks.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

- build a Python 3.11.8 / Ubuntu Docker image
- mount in `$PWD`
- execute notebook(s)
- clean results (remove execution/timing metadata, canonicalize outputs)
@flying-sheep
Copy link
Member

Hi, thank you very much, this is a great idea. We really need to standardize a reproducibility story here, thank you for getting started here. I don‘t think pip install will install the same versions without pip-timemachine or a lockfile, so this is not completely reproducible. It would be amazing though if we found a way to get pixel-perfect graphics that don‘t generate a diff every time.

One thing about your solution: The font rendering is kind of ugly. Can you check if installing ipycytoscape instead of graphviz (and maybe also if setting dask’s config visualization.engine to it) improves this?

regenerate.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants