Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/private-input: Unconstrained memory init #617

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

naure
Copy link
Collaborator

@naure naure commented Nov 21, 2024

Issues #614 and #607

Initialize memory with unconstrained prover hints.

  • It is practically identical to the zero-init circuit; just without the zero-init part.
  • The address range must be contiguous, but its size is dynamic.
  • The u32 range check is already done by the LOAD and STORE circuits.

e2e integration will be done in another PR. Need #608 to configure the address space.

Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Are we going to have e2e done in this PR? since #608 has merged :)

@naure naure merged commit 17a9d25 into master Nov 21, 2024
6 checks passed
@naure naure deleted the feat/private-input branch November 21, 2024 16:07
naure added a commit that referenced this pull request Nov 25, 2024
_Issue #614_.
_Pending a solution in #625_

- Load the private input from a file.
- Configuration of the address range.
- Integrate the circuit  (#617) in MMU.

---------

Co-authored-by: Aurélien Nicolas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants