Skip to content

Commit

Permalink
feat/private-input: remove draft
Browse files Browse the repository at this point in the history
  • Loading branch information
Aurélien Nicolas committed Nov 21, 2024
1 parent 931d942 commit feb0225
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
1 change: 1 addition & 0 deletions ceno_zkvm/src/instructions/riscv/memory/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ impl<E: ExtensionField, I: RIVInstruction, const N_ZEROS: usize> Instruction<E>
) -> Result<Self::InstructionConfig, ZKVMError> {
let rs1_read = UInt::new_unchecked(|| "rs1_read", circuit_builder)?; // unsigned 32-bit value
let rs2_read = UInt::new_unchecked(|| "rs2_read", circuit_builder)?;
// Memory initialization is not guaranteed to contain u32. Decompose in [u16; 2] here.
let prev_memory_value = UInt::new(|| "prev_memory_value", circuit_builder)?;
let imm = circuit_builder.create_witin(|| "imm"); // signed 12-bit value

Expand Down
17 changes: 0 additions & 17 deletions ceno_zkvm/src/tables/ram/ram_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -405,20 +405,3 @@ impl<DVRAM: DynVolatileRamTable + Send + Sync + Clone> DynVolatileRamTableConfig
Ok(final_table)
}
}

#[allow(dead_code)]
/// DynUnConstrainRamTableConfig with unconstrain init value and final value
/// dynamic address as witin, relied on augment of knowledge to prove address form
/// do not check init_value
/// TODO implement DynUnConstrainRamTableConfig
#[derive(Clone, Debug)]
pub struct DynUnConstrainRamTableConfig<RAM: DynVolatileRamTable + Send + Sync + Clone> {
addr: WitIn,

init_v: Vec<WitIn>,

final_v: Vec<WitIn>,
final_cycle: WitIn,

phantom: PhantomData<RAM>,
}

0 comments on commit feb0225

Please sign in to comment.