u8 table #234
Closed
u8 table #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naure
requested review from
kunxian-xia and
hero78119
and removed request for
kunxian-xia
Closed
Merged
|
See the generic version for all range tables: #236 |
hero78119
pushed a commit
that referenced
this pull request
Sep 18, 2024
_Issue #214_ A generalization of #234 for all range or scalar tables. - Moved and refactored the implementation of u16. - Implementation without generics because I find it cleaner and it compiles faster. - Definition of separate circuits `U5TableCircuit`, `U8TableCircuit`, `U16TableCircuit` using a parameter trait. - Fix soundness of `assert_u8`. --------- Co-authored-by: Aurélien Nicolas <[email protected]>
hero78119
pushed a commit
that referenced
this pull request
Sep 30, 2024
_Issue #214_ A generalization of #234 for all range or scalar tables. - Moved and refactored the implementation of u16. - Implementation without generics because I find it cleaner and it compiles faster. - Definition of separate circuits `U5TableCircuit`, `U8TableCircuit`, `U16TableCircuit` using a parameter trait. - Fix soundness of `assert_u8`. --------- Co-authored-by: Aurélien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #214.
Simpler fix than #225.