u8 pair table #225
Closed
u8 pair table #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
reviewed
Sep 16, 2024
| @@ -242,7 +242,7 @@ impl<const M: usize, const C: usize, E: ExtensionField> UInt<M, C, E> { | |||
| let limbs = (0..k) | |||
| .map(|_| { | |||
| let w = circuit_builder.create_witin(|| "").unwrap(); | |||
| circuit_builder.assert_byte(|| "", w.expr()).unwrap(); | |||
| circuit_builder.assert_byte_slow(|| "", w.expr()).unwrap(); | |||
There was a problem hiding this comment.
A bit concern is about this extra overhead on original "assert_byte" since it will occur a slow version.
To address this, an option is iterating limbs via chunk(2) therefore assert_u8_pair works.
There are other place to invoke assert_byte() directly
Line 285 in b300e9b
Which I believe for potiential performance pitfall we should refactor it traverse in chunk as well
Closed
|
Replaced by the simpler #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #214