Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations update from Hosted Weblate #23

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Translations update from Hosted Weblate #23

merged 3 commits into from
Jul 23, 2024

Conversation

weblate
Copy link
Collaborator

@weblate weblate commented Jun 23, 2024

Translations update from Hosted Weblate for Scribe/Scribe-i18n.

Current translation status:

Translation status

@henrikth93 @weblate
Translated using Weblate (Swedish)
f2c989d 
Currently translated at 74.1% (43 of 58 strings)

Translation: Scribe/Scribe-i18n
Translate-URL: https://hosted.weblate.org/projects/scribe/scribe-i18n/sv/
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 23, 2024 •
edited by andrewtavis
Loading

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Localization rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@henrikth93 @weblate
Translated using Weblate (Swedish)
65d4274 
Currently translated at 98.2% (57 of 58 strings)

Translation: Scribe/Scribe-i18n
Translate-URL: https://hosted.weblate.org/projects/scribe/scribe-i18n/sv/
wkyoshida
wkyoshida approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@wkyoshida wkyoshida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a quick note on something we could try on Weblate, but we should just be good with this Weblate PR?

Scribe-i18n/sv.json
Comment on lines +57 to +59
"app.about.appHint": "Här kan du lära dig mer om Scribe och dess community.",
"app.installation.appHint": "Följ instruktionerna nedan för att installera Scribe-tangentbord på din enhet.",
"app.settings.appHint": "Inställningar för appen och installerade tangentbord finns här."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is these keys were added after the sv.json file was created? Which might be why Weblate simply appended them to the end of the json body

Made me wonder if there's a way for us to configure Weblate to sort the keys for us automatically. Looks like there might be!? 👀🤔 There's a Customize JSON output addon that seems like we could activate? Might need to be an admin on the Weblate project to add it though

@andrewtavis
Copy link
Member

Hey @wkyoshida! 👋 Thanks for looking into the sorting! Makes total sense, and I'll look into that. As far as this is concerned, let's wait on @henrikth93 to send along the last two strings and then we'll be good to merge 😊

@henrikth93 @weblate
Translated using Weblate (Swedish)
dde9e54 
Currently translated at 100.0% (58 of 58 strings)

Translation: Scribe/Scribe-i18n
Translate-URL: https://hosted.weblate.org/projects/scribe/scribe-i18n/sv/
andrewtavis
andrewtavis approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @henrikth93! Stoked to have two languages ready for v3.1! 🚀

@andrewtavis andrewtavis merged commit b020823 into scribe-org:main Jul 23, 2024
@andrewtavis andrewtavis mentioned this pull request Jul 23, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkyoshida wkyoshida wkyoshida approved these changes

@andrewtavis andrewtavis andrewtavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weblate @andrewtavis @wkyoshida @henrikth93