Improve and simplify loading of transformation chains #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See docstring in
nxtransformations.py
for an explanation.I have added
class DependsOn
which seems a much saner way to handle the references, instead of juggling absolute and relative paths. The subclassTransformationChain
additionally hold the chain of transformations starting at the depends_on.Fixes #234 by introducing a new mechanism that can work around the shortcomings of the default data load. See there also for larger context.
Technically this represents a breaking change, since users would have to call
build()
after loading groups with transformations. In practice this is however typically not accessed directly — users typically usesnx.compute_positions
instead of working with the raw chains.