Expose NeXus transformation chains in workflow steps #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unused arg Compute component pos later Fix for non-nexus component "groups"
SimonHeybrock
commented
Oct 2, 2024
| return compute_component_position(loaded) | ||
| return loaded |
There was a problem hiding this comment.
This is the heart of the change in this PR: We are no longer computing the position directly here. This is moved into an extra step.
Previously we introduced false dependencies of detector ids on these.
SimonHeybrock
commented
Oct 3, 2024
| @@ -95,9 +91,9 @@ class TransmissionRun(Generic[ScatteringRunType]): | |||
| """Identifier for an arbitrary monitor""" | |||
| Monitor5 = NewType('Monitor5', int) | |||
| """Identifier for an arbitrary monitor""" | |||
| Incident = NewType('Incident', int) | |||
| IncidentMonitor = NewType('IncidentMonitor', int) | |||
There was a problem hiding this comment.
Added the monitor suffix here since these now show up as MyComponent[IndicidentMonitor] and it may be confusing without.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #96.
This is not completing this task, but does most of the prep work. The idea is that the
to_transformationcould accept additional arguments (or be replaced by one that does), which could:Neither 1.) nor 2.) is implemented right now. The initial focus will be on 1.). I would mainly like input from the reviewer on whether this new structure is adequate for this. The actual implementation of these features could be performed in follow-up work.
Depends on a release of scipp/scippnexus#243 (that is why CI is failing for now, otherwise this PR is ready for review).
Note that I ran into major (code) overhead/duplication from the current duplication (or near-duplication) of different code for different component types. Previously we had failed to find a way to generalize this. The reason was that monitors required one extra type-parameter (
MyMonitor[RunType, MonitorType]vsMyDetector[RunType],MySample[RunType], ...). I believe I have now solved this via the newComponentType. We can thus useMyComponent[Component, RunType]almost throughout, resulting in a significant deduplication. The "trick" is thatComponenttakes general component names except for the monitors, where there are multiple named ones.