ENH: Refactorization of MapieRegressor and ConformityScore #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 32 34 +2
Lines 3775 3881 +106
Branches 406 413 +7
==========================================
+ Hits 3775 3881 +106
☔ View full report in Codecov by Sentry. |
thibaultcordier
changed the title
added 2 commits
July 6, 2023 11:14
thibaultcordier
requested changes
Jul 12, 2023
There was a problem hiding this comment.
I'm only adding a few minor comments (description and moving if/else conditions). If @vincentblot28 has no further comments, I will approve the merging of these changes.
thibaultcordier
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Approve merging these changes. Looking forward to @vincentblot28's comments later today.
vincentblot28
approved these changes
Jul 13, 2023
thibaultcordier
deleted the
317-refactorization-of-mapieregressor-and-conformityscore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ConformityScore class called by MapieRegressor does not allow the scores to be calculated from X (only from y_pred).
To solve this problem a refactorization of MapieRegressor has been done : MapieRegressor now calls the EnsembleEstimator (defined in regression/estimator.py) that handle the training and usage of the estimator. The ConformityScore class is also modified : it now takes X and EnsembleEstimator in parameters.
Finally, the quantile calculation is intuitive according to the method (plus, base, minmax).
Fixes #317
Type of change
How Has This Been Tested?
Checklist
make lintmake type-checkmake testsmake coveragemake doc