Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorization of MapieRegressor and ConformityScore #317

Closed
candicemyt opened this issue Jun 22, 2023 · 0 comments · Fixed by #325
Closed

Refactorization of MapieRegressor and ConformityScore #317

candicemyt opened this issue Jun 22, 2023 · 0 comments · Fixed by #325
Assignees
Labels
developers Proposed by developers. enhancement New feature or request
Milestone

Comments

@candicemyt
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The method predict of MapieRegressor compute the upper and lower bound of the prediction intervals not very intuitively. Further more, the ConformityScore class called by MapieRegressor does not allow to calculate the scores from X (only from y_pred). It is a problem to implement new conformity scores that need this feature (like Conformal Residual Fitting).

Describe the solution you'd like

  • Refactorization of ConformityScore class : it would take X and estimator in parameters.
  • Re-order the way conformity scores, quantile and bounds are calculated. It would be the conformity score, then the quantile and finally the bounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers Proposed by developers. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants