Commits on Nov 29, 2023

1. 🎁 Add conditional PDF split or PDF.js …

   This is a preliminary commit to add conditional logic for either
   rendering PDF.js or IIIF viewer for split pages.
   
   There is a particular case where QA might appear to fail:
   
   1. Set the Tenant to use UV
   2. Create a work with a PDF (this will split the page)
   3. Go to the work's page, you'll see the UV
   4. Set the Tenant to use PDF.js
   5. Refresh the work page, and you should see PDF.js but instead will see
      the UV.
   
   To work around this (and realistically how most people will experience this):
   
   1. Set the Tenant to use UV
   2. Create a work with a PDF
   3. Go to the Dashboard
   4. Click the work's URL
   5. You should see a UV for the PDF
   6. Close the work's page
   7. Change the tenant to use PDF.js
   8. Go to the Dashboard
   9. Click the work's URL
   
   The conjecture is that there's some iframe and/or turbolinks caching.
   Given that this is an edge case regarding toggling on and off a tenant
   feature, we think the work around is adequate.
   
   Related to:
   
   - scientist-softserv/palni-palci#666
   - scientist-softserv/palni-palci#675
   - scientist-softserv/palni-palci#704
   - scientist-softserv/palni-palci#705
   - #162
   
   Co-authored-by: Shana Moore <[email protected]>
   Co-authored-by: Kirk Wang <[email protected]>

   

   3 people committed Nov 29, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for a2d1d36
   • Browse repository at this point

   Copy the full SHA

   a2d1d36 View commit details

   Browse the repository at this point in the history