🎁 Add conditional PDF split or PDF.js #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
approved these changes
Nov 29, 2023
docker-compose.bundle.yml
Outdated
| # Only use for local development | ||
| version: '3.8' | ||
| services: | ||
| # Uncomment to allow for the use of a ruby debugger (byebug, pry, etc) in Docker. |
There was a problem hiding this comment.
The comment says this is uncommented for debugging... is this intended to be committed uncommented?
This is a preliminary commit to add conditional logic for either rendering PDF.js or IIIF viewer for split pages. There is a particular case where QA might appear to fail: 1. Set the Tenant to use UV 2. Create a work with a PDF (this will split the page) 3. Go to the work's page, you'll see the UV 4. Set the Tenant to use PDF.js 5. Refresh the work page, and you should see PDF.js but instead will see the UV. To work around this (and realistically how most people will experience this): 1. Set the Tenant to use UV 2. Create a work with a PDF 3. Go to the Dashboard 4. Click the work's URL 5. You should see a UV for the PDF 6. Close the work's page 7. Change the tenant to use PDF.js 8. Go to the Dashboard 9. Click the work's URL The conjecture is that there's some iframe and/or turbolinks caching. Given that this is an edge case regarding toggling on and off a tenant feature, we think the work around is adequate. Related to: - scientist-softserv/palni-palci#666 - scientist-softserv/palni-palci#675 - scientist-softserv/palni-palci#704 - scientist-softserv/palni-palci#705 - #162 Co-authored-by: Shana Moore <[email protected]> Co-authored-by: Kirk Wang <[email protected]>
jeremyf
force-pushed
the
conditional-iiif-print
branch
from
8d35981
to
a2d1d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary commit to add conditional logic for either
rendering PDF.js or IIIF viewer for split pages.
There is a particular case where QA might appear to fail:
the UV.
To work around this (and realistically how most people will experience this):
The conjecture is that there's some iframe and/or turbolinks caching.
Given that this is an edge case regarding toggling on and off a tenant
feature, we think the work around is adequate.
Related to:
Co-authored-by: Shana Moore [email protected]
Co-authored-by: Kirk Wang [email protected]