Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table-footer): added styling according to designer feedback #810

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+32 −3
Open

fix(table-footer): added styling according to designer feedback #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a34f293
fix: added styling to page dropdown according to designer feedback
Lunkan89 Oct 25, 2024
dd108c4
fix: fixed failing tests
Lunkan89 Oct 25, 2024
84f677a
fix: fixed failing test
Lunkan89 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/components/dropdown/dropdown-button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
width: 100%;
background-color: var(--tds-dropdown-bg);
border-bottom: 1px solid var(--tds-dropdown-border-bottom);
border-radius: 4px 4px 0 0;
border-radius: var(--tds-dropdown-border-radius);

&:hover {
border-bottom: 1px solid var(--tds-dropdown-border-bottom-hover);
Expand Down
14 changes: 12 additions & 2 deletions packages/core/src/components/dropdown/dropdown-vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
--tds-dropdown-helper-color: var(--tds-grey-700);
--tds-dropdown-placeholder-color: var(--tds-grey-700);
--tds-dropdown-disabled-color: var(--tds-grey-400);
--tds-dropdown-border-radius: 4px 4px 0 0;

.tds-mode-variant-primary {
--tds-dropdown-bg: var(--tds-grey-50);
Expand All @@ -20,8 +21,12 @@
}

tds-table-footer {
--tds-dropdown-bg: transparent;
--tds-dropdown-bg: white;
--tds-placeholder-margin: var(--tds-spacing-element-8);
--tds-dropdown-border-bottom: transparent;
--tds-dropdown-border-bottom-hover: transparent;
--tds-dropdown-border-bottom-open: transparent;
--tds-dropdown-border-radius: 4px;
}
}

Expand All @@ -36,6 +41,7 @@
--tds-dropdown-helper-color: var(--tds-grey-500);
--tds-dropdown-placeholder-color: var(--tds-grey-400);
--tds-dropdown-disabled-color: var(--tds-grey-800);
--tds-dropdown-border-radius: 4px 4px 0 0;

.tds-mode-variant-primary {
--tds-dropdown-bg: var(--tds-grey-868);
Expand All @@ -46,7 +52,11 @@
}

tds-table-footer {
--tds-dropdown-bg: transparent;
--tds-dropdown-bg: var(--tds-grey-868);
--tds-placeholder-margin: var(--tds-spacing-element-8);
--tds-dropdown-border-bottom: transparent;
--tds-dropdown-border-bottom-hover: transparent;
--tds-dropdown-border-bottom-open: transparent;
--tds-dropdown-border-radius: 4px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--tds-dropdown-border-radius: 4px;
--tds-dropdown-border-radius: var(--tds-spacing-element-4);

I know this isn't the case in other components either, but should these not use the spacing vars instead?

--tds-spacing-element-4

}
}
19 changes: 19 additions & 0 deletions packages/core/src/components/dropdown/dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,32 @@
.dropdown-select {
position: relative;

button:focus {
border-bottom-color: var(--tds-dropdown-border-bottom);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been part of the discussion around these updated styles, should the dropdown not have any blue border when focused like the input field for number of pages?

}
button {
border-bottom-color: var(--tds-dropdown-border-bottom);
}

button.error {
border-bottom-color: var(--tds-negative);
}

button.error:focus {
border-bottom-color: transparent;
}

&.disabled {
.label-inside,
.placeholder,
.label-inside-as-placeholder,
.value-wrapper {
color: var(--tds-dropdown-disabled-color);
}

button {
border: none;
}
}

.label-inside {
Expand Down
Binary file modified ...s-snapshots/tds-table-pagination-renders-pagination-table-correctly-1-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading