-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table-footer): added styling according to designer feedback #810
base: develop
Are you sure you want to change the base?
Conversation
Playwright test resultsDetails 391 tests across 132 suites Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Quality Gate passedIssues Measures |
--tds-dropdown-border-bottom: transparent; | ||
--tds-dropdown-border-bottom-hover: transparent; | ||
--tds-dropdown-border-bottom-open: transparent; | ||
--tds-dropdown-border-radius: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--tds-dropdown-border-radius: 4px; | |
--tds-dropdown-border-radius: var(--tds-spacing-element-4); |
I know this isn't the case in other components either, but should these not use the spacing vars instead?
--tds-spacing-element-4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Johan! ⭐
@@ -23,13 +23,32 @@ | |||
.dropdown-select { | |||
position: relative; | |||
|
|||
button:focus { | |||
border-bottom-color: var(--tds-dropdown-border-bottom); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been part of the discussion around these updated styles, should the dropdown not have any blue border when focused like the input field for number of pages?
Describe pull-request
Made changes according to designer feedback
Issue Linking:
Choose one of the following options
How to test
Provide detailed steps for testing, including any necessary setup.
Checklist before submission
npm run build-all
without errorsSuggested test steps
Screenshots
Darkmode:
Closed:
Opened:
Lightmode:
Closed:
Opened: