Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table-footer): added styling according to designer feedback #810

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix(table-footer): added styling according to designer feedback #810

wants to merge 3 commits into from
+32 −3

Conversation

Lunkan89
Copy link
Collaborator

@Lunkan89 Lunkan89 commented Oct 25, 2024 •
edited by jira bot
Loading

Describe pull-request

Made changes according to designer feedback

Issue Linking:

Choose one of the following options

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to...
  2. Check in...
  3. Run ...

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Darkmode:
Closed:
Screenshot 2024-10-25 at 15 11 06

Opened:
Screenshot 2024-10-25 at 15 11 10

Lightmode:
Closed:
Screenshot 2024-10-25 at 15 10 51

Opened:
Screenshot 2024-10-25 at 15 10 58

@Lunkan89 Lunkan89 self-assigned this Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Playwright test results

passed  390 passed
skipped  1 skipped

Details

stats  391 tests across 132 suites
duration  51.9 seconds
commit  84f677a

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@aws-amplify-eu-north-1 AWS Amplify (eu-north-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-810.d3fazya28914g3.amplifyapp.com

@Lunkan89 Lunkan89 changed the title fix: added styling to page dropdown according to designer feedback fix(table-footer): added styling according to designer feedback Oct 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mJarsater
mJarsater reviewed Oct 28, 2024
View reviewed changes
packages/core/src/components/dropdown/dropdown-vars.scss
--tds-dropdown-border-bottom: transparent;
--tds-dropdown-border-bottom-hover: transparent;
--tds-dropdown-border-bottom-open: transparent;
--tds-dropdown-border-radius: 4px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--tds-dropdown-border-radius: 4px;
--tds-dropdown-border-radius: var(--tds-spacing-element-4);

I know this isn't the case in other components either, but should these not use the spacing vars instead?

--tds-spacing-element-4

ckrook
ckrook approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ckrook ckrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Johan! ⭐

nathalielindqvist
nathalielindqvist reviewed Oct 28, 2024
View reviewed changes
packages/core/src/components/dropdown/dropdown.scss
@@ -23,13 +23,32 @@
.dropdown-select {
position: relative;

button:focus {
border-bottom-color: var(--tds-dropdown-border-bottom);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been part of the discussion around these updated styles, should the dropdown not have any blue border when focused like the input field for number of pages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathalielindqvist nathalielindqvist nathalielindqvist left review comments

@mJarsater mJarsater mJarsater left review comments

@ckrook ckrook ckrook approved these changes

@theJohnnyMe theJohnnyMe Awaiting requested review from theJohnnyMe

At least 2 approving reviews are required to merge this pull request.

Assignees

@Lunkan89 Lunkan89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lunkan89 @ckrook @nathalielindqvist @mJarsater