-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Java 11 or later #30
Conversation
Thank you! Can we test Kelpie with all Java versions we support in the CI? kelpie/.github/workflows/kelpie.yaml Line 23 in 05dc78a
|
@yito88 I'm okay to update the workflow file to execute
What do you think? |
Right, we could add some integration tests. How about running small ones with scalar-labs/kelpie-test in the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI stuff could be separated from this PR
@yito88 Thanks for the suggestion! It sounds good. I'll try it when I have a time later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This PR fixes #29.
The current implementation tries to cast
jdk.internal.loader.ClassLoaders$AppClassLoader
tojava.net.URLClassLoader
. It works in Java 8, but doesn't work in Java 11 or later sinceClassLoaders$AppClassLoader
no longer inheritjava.net.URLClassLoader
.The PR also upgrades the version of Guice since version 4 doesn't work with Java 17 or later.
I confirmed if this change works as follows:
./gradlew installDist
in the Kelpie project directory using Java 8