Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test #31

Merged
merged 10 commits into from
Dec 27, 2024
Merged

Add integration test #31

merged 10 commits into from
Dec 27, 2024

Conversation

komamitsu
Copy link
Contributor

@komamitsu komamitsu commented Dec 20, 2024

As per discussion with @yito88 #30 (comment), we plan to add an integration test to see if Kelpie can work with Java 11 or later in addition to Java 8. This PR adds a simple integration test for that with minimum effort.

This PR includes:

  • Add GitHub Actions steps to setup kelpie-test:print-modules and execute it with internally built Kelpie
  • Upgrade the Gradle version to 8.11
  • Update build.gradle to work with Gradle 8 since recent Javas require it.

@komamitsu komamitsu force-pushed the add-integration-test branch from ad41116 to f9e6826 Compare December 25, 2024 03:16
@komamitsu komamitsu marked this pull request as ready for review December 25, 2024 05:37
@komamitsu komamitsu self-assigned this Dec 25, 2024
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 80e0265 into master Dec 27, 2024
8 checks passed
@brfrn169 brfrn169 deleted the add-integration-test branch December 27, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants