Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Ycheck scala2-library-bootstrapped once #18732

Conversation

nicolasstucki
Copy link
Contributor

We only Ycheck the compilation of scala2-library-bootstrapped once. This test the -Yscala2-stdlib flag. We do this on the MiMa test to avoid the large overhead of Ycheck when compiling scala3-bootstrapped.

@nicolasstucki nicolasstucki force-pushed the only-ycheck-scala2-library-bootstrapped-once branch 2 times, most recently from e4fd208 to 9bad82b Compare October 20, 2023 12:14
@nicolasstucki nicolasstucki self-assigned this Oct 20, 2023
@nicolasstucki nicolasstucki force-pushed the only-ycheck-scala2-library-bootstrapped-once branch from 9bad82b to c40047f Compare October 20, 2023 15:46
@nicolasstucki nicolasstucki marked this pull request as ready for review October 23, 2023 07:50
@nicolasstucki nicolasstucki requested a review from sjrd October 23, 2023 07:50
@nicolasstucki nicolasstucki assigned sjrd and unassigned nicolasstucki Oct 23, 2023
We only `Ycheck` the compilation of `scala2-library-bootstrapped` once.
This test the `-Ycompile-scala2-library` flag. We do this on the MiMa
test to avoid the large overhead of `Ycheck` when compiling
`scala3-bootstrapped`.
@nicolasstucki nicolasstucki force-pushed the only-ycheck-scala2-library-bootstrapped-once branch from c40047f to ff6c339 Compare October 24, 2023 07:46
@nicolasstucki nicolasstucki merged commit 6aa24fa into scala:main Oct 24, 2023
@nicolasstucki nicolasstucki deleted the only-ycheck-scala2-library-bootstrapped-once branch October 24, 2023 09:18
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants