Skip to content

Commit

Permalink
Only Ycheck scala2-library-bootstrapped once (#18732)
Browse files Browse the repository at this point in the history
We only Ycheck the compilation of scala2-library-bootstrapped once. This
test the -Yscala2-stdlib flag. We do this on the MiMa test to avoid the
large overhead of Ycheck when compiling scala3-bootstrapped.
  • Loading branch information
nicolasstucki authored Oct 24, 2023
2 parents 44a537b + ff6c339 commit 6aa24fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion project/Build.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,6 @@ object Build {
},
Compile / doc / scalacOptions += "-Ydocument-synthetic-types",
scalacOptions += "-Ycompile-scala2-library",
scalacOptions += "-Ycheck:all",
scalacOptions -= "-Xfatal-warnings",
ivyConfigurations += SourceDeps.hide,
transitiveClassifiers := Seq("sources"),
Expand Down
3 changes: 2 additions & 1 deletion project/scripts/scala2-library-tasty-mima.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ setTastyVersion $MINOR_TASTY_VERSION_SUPPORTED_BY_TASTY_MIMA 0
# Run scala2-library-bootstrapped/tastyMiMaReportIssues using a custom TASTy version.
# We clean before to make sure all sources are recompiled using the new TASTY version.
# We clean after to make sure no other test will use the TASTy generated with this version.
"$SBT" "clean; scala2-library-bootstrapped/clean; reload; scala2-library-bootstrapped/tastyMiMaReportIssues; clean; scala2-library-bootstrapped/clean"
# We set -Ycheck:all to check that -Ycompile-scala2-library does not gererate inconsistent trees.
"$SBT" 'clean; scala2-library-bootstrapped/clean; reload; set `scala2-library-bootstrapped`/scalacOptions += "-Ycheck:all"; scala2-library-bootstrapped/tastyMiMaReportIssues; clean; scala2-library-bootstrapped/clean'

setTastyVersion $MINOR_TASTY_VERSION $EXPERIMENTAL_TASTY_VERSION

0 comments on commit 6aa24fa

Please sign in to comment.