Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.4.0 blogpost #1598

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Add 3.4.0 blogpost #1598

merged 10 commits into from
Feb 29, 2024

Conversation

Kordyjan
Copy link
Contributor

I was sick for most of the last week, so the release blog post is late, and I haven't had enough time to give it proper care. I hope it will pass.

@Kordyjan Kordyjan requested a review from SethTisue February 22, 2024 17:19
SethTisue
SethTisue reviewed Feb 22, 2024
View reviewed changes
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-xx-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
@xuwei-k xuwei-k mentioned this pull request Feb 23, 2024
Merged
@Kordyjan @SethTisue @bishabosha
Apply suggestions from code review
c80870d 
Co-authored-by: Seth Tisue <[email protected]>
Co-authored-by: Jamie Thompson <[email protected]>
xuwei-k added a commit to scalatra/scalamd that referenced this pull request Feb 23, 2024
@xuwei-k
revert to Scala 3.3
22e2bb3 
> Scala 3.4.0 code can depend on dependencies compiled with Scala 3.3.x, but not the other way around. That means that if you are a library author, you should consider staying on the LTS line.

scala/scala-lang#1598
@Kordyjan
Copy link
Contributor Author

The post is ready. I applied all the suggestions. Moreover, I put 3.4.0 changes into categories and expanded the compatibility section.

SethTisue
SethTisue reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the categorization and prioritization of the bullets looks great 👍

remaining suggestions are mostly just polish. 1 or 2 a bit more substantive.

blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
@Kordyjan @SethTisue @bishabosha
Apply suggestions from code review
8f1067a 
Co-authored-by: Seth Tisue <[email protected]>
Co-authored-by: Jamie Thompson <[email protected]>
@Kordyjan Kordyjan marked this pull request as ready for review February 26, 2024 15:04
@sjrd
Copy link
Member

sjrd commented Feb 28, 2024

⚠️ We might have to bankrupt 3.3.2: playframework/playframework#12418

It produces .tasty files that cannot be read by 3.3.0 and 3.3.1.

@mkurz mkurz mentioned this pull request Feb 28, 2024
Closed
lbialy
lbialy suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@lbialy lbialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comms around 3.3.2

_data/scala-releases.yml Outdated Show resolved Hide resolved
_data/scala-releases.yml Outdated Show resolved Hide resolved
_downloads/2024-02-26-3.3.2.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-26-scala-3.4.0-and-3.3.2-released.md Outdated Show resolved Hide resolved
@Kordyjan Kordyjan mentioned this pull request Feb 28, 2024
Closed
14 tasks
bishabosha
bishabosha reviewed Feb 29, 2024
View reviewed changes
blog/_posts/2024-02-29-scala-3.4.0-and-3.3.3-released.md
@@ -4,6 +4,9 @@ post-type: blog
by: Paweł Marks, VirtusLab
title: Scala 3.4.0 and 3.3.3 LTS released!
---

![Scala 3.4]({{ site.baseurl }}/resources/img/scala-3.4-launch.jpg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@Kordyjan @arixmkii @bishabosha
Apply suggestions from code review
213ef9f 
Co-authored-by: Arthur S <[email protected]>
Co-authored-by: Jamie Thompson <[email protected]>
@Kordyjan Kordyjan merged commit 0dd24d0 into main Feb 29, 2024
1 check passed
@SethTisue SethTisue deleted the release-3.4.0 branch February 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arixmkii arixmkii arixmkii left review comments

@bishabosha bishabosha bishabosha left review comments

@bjaglin bjaglin bjaglin left review comments

@lbialy lbialy lbialy requested changes

@SethTisue SethTisue SethTisue approved these changes

Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kordyjan @sjrd @SethTisue @bjaglin @lbialy @bishabosha @arixmkii