-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Scala to 3.3.3 #855
Conversation
ab3e0f8
to
1b6f33a
Compare
Follow-up on apache#855 Gets us the fix for scala/scala3#18210
refs: playframework/playframework#12418 Need to wait for the bug in 3.3.2 to get fixed before merge this |
Scala 3.3.2 might even be dropped: |
3.3.3 is on maven central - scala/scala3#19820 (comment) Still would be wary of merging this even if it passes CI. I'd prefer to wait a few days to see if there are further issues. |
We can even wait a week, M1 is in no rush for 1.1.x and 1.0.3-M1 was just released now |
I think you mean 1.0.3-m1, and I think we can backport 3.3.3 to 1.0.x branch once the vote pass. |
Yes, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closing in favour of #1169 which is the same PR |
Scala 3.3.2-RC1 just came out so this PR is testing it out to see if the codebase compiles. It will remain in draft until full release of Scala 3.3.2 is out.