Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades + require sbt 1.9.7 as minimum #216

Merged
merged 2 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- { sbtCrossVersion: "1.4.9", jvmName: "temurin:1.11.0" }
- { sbtCrossVersion: "1.9.7", jvmName: "temurin:1.11.0" }
# { jvmName: "temurin:1.11.0" }
# { jvmName: "temurin:1.17.0" }
steps:
Expand Down
9 changes: 2 additions & 7 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ inThisBuild(Seq(

val pluginSettings = Seq(
sbtPlugin := true,
crossSbtVersions := List("1.4.9"),
crossSbtVersions := List("1.9.7"),
scriptedLaunchOpts += "-Dproject.version=" + version.value
// scriptedBufferLog := false
)
Expand Down Expand Up @@ -67,11 +67,6 @@ lazy val core = project
"ws.unfiltered" %% "unfiltered-filter" % unfilteredVersion,
"ws.unfiltered" %% "unfiltered-jetty" % unfilteredVersion,
"ws.unfiltered" %% "unfiltered-specs2" % unfilteredVersion % Test,
).map(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! Seems this is now fixed via

// Force sbt-site to Scala XML 2.1
_.exclude("org.scala-lang.modules", "scala-xml_2.12")
) ++ Seq(
"org.scala-lang.modules" %% "scala-xml" % "2.1.0"
)
)

Expand Down Expand Up @@ -132,7 +127,7 @@ lazy val paradox = project
.in(file("paradox"))
.settings(
name := "sbt-site-paradox",
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.10.3")
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.10.6")
)
.dependsOn(core)
.enablePlugins(SbtPlugin)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
addSbtPlugin("com.github.sbt" % "sbt-site" % sys.props("project.version"))
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.1")
addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
addSbtPlugin("com.github.sbt" % "sbt-site" % sys.props("project.version"))
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.1")
addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# When updating also change the minimum version noted in src/main/paradox/index.md
sbt.version=1.4.9
sbt.version=1.9.7
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,4 @@ addSbtPlugin("com.github.sbt" % "sbt-site" % sys.props("project.version"))

resolvers += "jgit-repo" at "https://download.eclipse.org/jgit/maven"

addSbtPlugin(
("com.github.sbt" % "sbt-ghpages" % "0.7.0")
// sbt-ghpages depends on sbt-site 1.4.1, which pulls Scala XML 1.x
.exclude("org.scala-lang.modules", "scala-xml_2.12")
)
addSbtPlugin("com.github.sbt" % "sbt-ghpages" % "0.8.0")
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.4.9
sbt.version=1.9.7
2 changes: 1 addition & 1 deletion laika/src/sbt-test/laika/minimal/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.4.9
sbt.version=1.9.7
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.8.2
sbt.version=1.9.7
14 changes: 4 additions & 10 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
addSbtPlugin("com.github.sbt" % "sbt-site-paradox" % "1.5.0")
//#sbt-ghpages
addSbtPlugin(
("com.github.sbt" % "sbt-ghpages" % "0.7.0")
// sbt-ghpages depends on sbt-site 1.4.1, which pulls Scala XML 1.x
.exclude("org.scala-lang.modules", "scala-xml_2.12")
)
addSbtPlugin("com.github.sbt" % "sbt-ghpages" % "0.8.0")
//#sbt-ghpages
addSbtPlugin("io.github.jonas" % "sbt-paradox-material-theme" % "0.6.0")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.11")
addSbtPlugin("com.github.sbt" % "sbt-paradox-material-theme" % "0.7.0")
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.10.6") // https://www.scala-sbt.org/sbt-paradox-material-theme/getting-started.html#jdk-11-
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.12")

libraryDependencies += "org.scala-sbt" %% "scripted-plugin" % sbtVersion.value

libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % "always"
libraryDependencySchemes += "org.scala-lang.modules" %% "scala-parser-combinators" % "always"
1 change: 1 addition & 0 deletions src/main/paradox/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Before upgrading please consult the @github:[release notes](/notes/). Instructio

@@@ note

* Version 1.6+ is published for sbt >= 1.9.7 and requires Java 11+.
* Version 1.5+ is published for sbt >= 1.4.9 and requires Java 11+.
* Version 1.4+ is published for sbt 1.2.x.
* Version 1.3+ is cross published to both sbt 0.13 and sbt 1.x.
Expand Down
4 changes: 4 additions & 0 deletions src/main/paradox/migration-guide.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Migration Guide

## Migrating from version 1.5.x to 1.6.x

Only sbt >=1.9.7 is supported.

## Migrating from version 1.4.x to 1.5.x

To cut down on dependencies, sbt-site is now spilt into separate modules per site generator. Three generators are available as specific sbt plugins:
Expand Down
Loading