Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades + require sbt 1.9.7 as minimum #216

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Feb 21, 2024

No description provided.

@mkurz mkurz changed the title Dependeny upgrades + require sbt 1.9.7 as minimum Dependency upgrades + require sbt 1.9.7 as minimum Feb 21, 2024
@mkurz mkurz marked this pull request as draft February 21, 2024 14:02
@mkurz
Copy link
Member Author

mkurz commented Feb 21, 2024

Without increasing sbt to 1.9.7 we get errors like following (it seems some of the upgraded libraries are incompatible with older sbt):

[info] Running paradox/can-use-paradox
...
[info] [info] loading settings for project sbt_8fd99a15 from build.sbt ...
Error:  java.lang.NoSuchMethodError: 'java.io.File sbt.Defaults$.makeCrossTarget(java.io.File, java.lang.String, java.lang.String, java.lang.String, boolean, boolean)'
Error:  	at com.typesafe.sbt.web.SbtWeb$.$anonfun$buildSettings$6(SbtWeb.scala:153)
Error:  	at scala.Function1.$anonfun$compose$1(Function1.scala:49)
Error:  	at sbt.internal.util.EvaluateSettings$MixedNode.evaluate0(INode.scala:228)
Error:  	at sbt.internal.util.EvaluateSettings$INode.evaluate(INode.scala:170)
Error:  	at sbt.internal.util.EvaluateSettings.$anonfun$submitEvaluate$1(INode.scala:87)
Error:  	at sbt.internal.util.EvaluateSettings.sbt$internal$util$EvaluateSettings$$run0(INode.scala:99)
Error:  	at sbt.internal.util.EvaluateSettings$$anon$3.run(INode.scala:94)
Error:  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
Error:  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at sbt.scriptedtest.ScriptedTests.runOrHandleDisabled(ScriptedTests.scala:266)
Error:  	at java.base/java.lang.Thread.run(Thread.java:829)
[info] [error] java.lang.NoSuchMethodError: 'java.io.File sbt.Defaults$.makeCrossTarget(java.io.File, java.lang.String, java.lang.String, java.lang.String, boolean, boolean)'
[info] [error] Use 'last' for the full log.
...
Error:  x paradox/can-use-paradox 
	at sbt.scriptedtest.ScriptedTests.$anonfun$runBatchedTests$1(ScriptedTests.scala:236)
	at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286)
	at scala.collection.mutable.ArraySeq.foreach(ArraySeq.scala:75)
	at scala.collection.TraversableLike.map(TraversableLike.scala:286)
	at scala.collection.TraversableLike.map$(TraversableLike.scala:279)
	at scala.collection.AbstractTraversable.map(Traversable.scala:108)
	at sbt.scriptedtest.ScriptedTests.runBatchTests$1(ScriptedTests.scala:208)
...
[error] (core / scripted) Failed tests:
[error] 	scaladoc/can-aggregate
[error] 	site/can-have-custom-mappings
[error] 	site/can-run-generator-twice
[error] 	site/minimum-sbt-1.0
[error] (paradox / scripted) Failed tests:
[error] 	paradox/can-use-paradox

@mkurz mkurz marked this pull request as ready for review February 21, 2024 14:49
@mkurz mkurz closed this Feb 21, 2024
@mkurz mkurz reopened this Feb 21, 2024
@mkurz
Copy link
Member Author

mkurz commented Feb 21, 2024

Ready.

However it seems the required workflows are misconfigured (because below workflow, with this pr, does not exist anymore):
image

Copy link
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 2164968 into sbt:main Feb 29, 2024
3 checks passed
@mkurz mkurz deleted the dependeny_upgrades branch February 29, 2024 14:18
@@ -67,11 +67,6 @@ lazy val core = project
"ws.unfiltered" %% "unfiltered-filter" % unfilteredVersion,
"ws.unfiltered" %% "unfiltered-jetty" % unfilteredVersion,
"ws.unfiltered" %% "unfiltered-specs2" % unfilteredVersion % Test,
).map(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! Seems this is now fixed via

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants