Use route-maps instead of network for BGP prefixes #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current firmware of our Cisco routers (<= 17.6) requires a full sync every time we touch the bgp subtree via netconf-yang. For our current prod regions can cause a complete config lock of the /native tree, which can take up to two minutes. In this timeframe no other reconfiguration is possible. Before this commit we used network statements for advertising BGPVPNs and DAPNets. This is now done via "redistribute connected" and "redistribute static" + a route-map, to set the right communities for extraroutes overlapping with a DAPNet. The config will still get locked for DAPNet routers or when a BGPVPN is attached, but all subsequent modifications (like adding/deleting a subnet or adding/deleting an extraroute to the router) will only change a prefixlist and therefore not touch the BGP config tree. Long term it would be desirable if Cisco would fix their confd implementation, though. WIP: * config is still hardcoded, shouldn't be that way * we have to discuss if we want to advertise DAPNets via route-map or network statement
We now also advertise DAPNets via route-map. WIP: Commit will most likely be squashed
sebageek
force-pushed
the
advertise-bgpvpn-via-redist-route-map
branch
from
f6307e1
to
4142bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current firmware of our Cisco routers (<= 17.6) requires a full sync every time we touch the bgp subtree via netconf-yang. For our current prod regions can cause a complete config lock of the /native tree, which can take up to two minutes. In this timeframe no other reconfiguration is possible.
Before this commit we used network statements for advertising BGPVPNs and DAPNets. This is now done via "redistribute connected" and "redistribute static" + a route-map, to set the right communities for extraroutes overlapping with a DAPNet. The config will still get locked for DAPNet routers or when a BGPVPN is attached, but all subsequent modifications (like adding/deleting a subnet or adding/deleting an extraroute to the router) will only change a prefixlist and therefore not touch the BGP config tree.
Long term it would be desirable if Cisco would fix their confd implementation, though.
WIP: