Drop all compatibility for pre 17.6 fw versions #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebageek
force-pushed
the
driver-compat-cleanup
branch
from
23fc1d3
to
7e6dcc3
Compare
sebageek
force-pushed
the
driver-compat-cleanup
branch
3 times, most recently
from
6527236
to
dad545e
Compare
sven-rosenzweig
approved these changes
Oct 30, 2024
We are now on version >= 17.6 everywhere and therefore we can drop all code for previous versions (16.9, 17.3). This also makes writing new code easier, as we have to consider (and test) less versions (and even don't have any devices anymore to test the old code). This commit will only get rid off the version_min_17_x and drop_on_17_x version switch, BDI removal will be done in an extra commit.
Before we had BD-VIF/bridge support on our routes we needed to have a hyperloop cable (traversing two port channels, using up like two thirds of our router ports). Now that all of this is long behind us we can also remove the compatibility code for switching back to BDI. This means we remove the PortChannels LoopbackExternalInterface and LoopbackInternalInterface and also switch-over support by removing the bd_iftype (tied to an asr1k context), the use_bdvif flag (both on a context and in the oslo config part of the driver) and the force_bdi flag (used to fetch BDIs on a router already on BD-VIFs so we can still remove them). VBInterface was renamed to BDInterface, same goes for the related classes VBPrimaryIpAddress, VBSecondaryIpAddress and VBInterfaceStats. For migrating the code I updated all conditionals in a way as if bd_iftype is always BD-VIF and use_bdvif is always True.
sebageek
force-pushed
the
driver-compat-cleanup
branch
from
dad545e
to
1c35493
Compare
ikatza-at-work
approved these changes
Nov 1, 2024
swagner-de
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now on version >= 17.6 everywhere and therefore we can drop all code for previous versions (16.9, 17.3). This also makes writing new code easier, as we have to consider (and test) less versions (and even don't have any devices anymore to test the old code).
For now I left the BDI code intact, as my main goal was to get rid of all version_min_17_x and drop_on_17_x, but we can also think about removing that in the future.BDI code has been removed in second commit.