Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service graines required for backupninja #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avlasov-mos-de
Copy link

List of related PRs coming later

@cloudlab-autobuild
Copy link
Contributor

Can one of the admins verify this patch?

fs_includes: []
fs_excludes: []
actions:
- cmd: "rsync -aH --exclude='/var/lib/maas/boot-resources' --relative /etc/maas /var/lib/maas /var/backups/maas_config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you use just fs_includes and excludes above?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise I wont be able to store it in /var/backups/maas_config where I'm mounting glusterfs volume

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why do you want to store it in /var/backups/maas_config when backupninja takes care about backing up to proper location?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I use fs_include/exclude configs will be sent only to remote location, but idea was also to store them on glusterfs volume. in other words having local backup that is quickly accessible but not stored on the same node that is being backed up and remote copy

Copy link
Member

@fpytloun fpytloun May 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So use-case is to backup to multiple locations? Then you should add support into backupninja for this use-case, this behavior may not be desired for all deployments as MaaS data can be probably pretty heavy (all the images, etc.) and /var/backups is usually root volume.
Purpose of /var/backups is to have place where to collect some data before sending them to backup location (eg. data that are continuously changing, et mysql database that you need to dump first). But it's not meant to be persistent or somehow reliable backup location.

@avlasov-mos-de
Copy link
Author

as you can see from the actual command I'm excluding imaged from backup(as they can be downloaded at any time) and should be really light. Also psql or mysql backups done the samr way they stored in /var/backups and the can be sync somewhere else

@epcim
Copy link
Member

epcim commented Oct 3, 2017

@fpytloun ?

@fpytloun
Copy link
Member

fpytloun commented Oct 5, 2017

But you still need to use fs_includes to make backup into remote location which is primary use-case, eg. freeipa is the same use-case:
https://github.com/salt-formulas/salt-formula-freeipa/blob/master/freeipa/meta/backupninja.yml#L4

But FreeIPA requires dump of database, etc. that's only reason why /var/lib/ipa/backup is used to make local backup before backing up remotely. I don't think it's required in this case as fs_includes and excludes should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants