Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add posibility turn of mysql backup for specific nodes, #1

Merged
merged 1 commit into from
May 22, 2018

Conversation

avlasov-mos-de
Copy link
Contributor

fix rsync creating remote directories, add import vars revquired for loading cassandra service_grains.
List of related PRs coming later

@cloudlab-autobuild
Copy link
Collaborator

Can one of the admins verify this patch?

@@ -1,3 +1,4 @@
{%- from "linux/map.jinja" import system with context %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed, why did you add it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have parametrized meta/backupninja.ymk for contrail formula(check contrail formula PR) so when we load it service_grains jinja should be able to render it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but grains should be used instead.

…ating remote directories,

   add import vars revquired for loading cassandra service_grains.
@jiribroulik
Copy link
Contributor

Why are you not using xtrabackup for galera/mysql backups?

@maestropandy
Copy link

@slimakcz
Copy link
Contributor

changes in backupninja/client.sls are really useful, because I have the same issue. I using xtrabackup for galera/mysql backups and for moving data to backup server I would like to use backupninja. I disabled backupninja for mysql in reclass model, but mysql handler was still generated.
Similar issue is with backup cassandra on network nodes, because I enabled backupninja, disable mysql backup, but I have mysql definition in reclass model, thus backupninja preparing mysql handler, but missing admin user/password (which is correct, I don't need this data on ntw node).

Copy link
Member

@epcim epcim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, an alternative to xtrabackup

@epcim epcim merged commit 9e14077 into salt-formulas:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants