feat: col, line numbers on mdapi deploy errors

[mshanemc]

requires forcedotcom/source-deploy-retrieve#1130

What does this PR do?

• show col/line numbers on component fails
• sort the failures table better
• remove duplicate failure reporting

What issues does this PR fix or reference?

forcedotcom/cli#356
@W-14247072@

[cristiand391]

QA notes:

setup:
sf: @salesforce/cli/2.12.9 darwin-x64 node-v18.17.0
using dreamhouse, full deploy then modify GeocodingService apex class and try to deploy with invalid syntax in mdapi format:
sf project convert source --metadata ApexClass:GeocodingService --output-dir col-line-err

current scenario:
no col, line info in human output (but it is included in json), duplicate errors:

✅ Line:Column column in deploy failures, no duplicate errors:

➜  dreamhouse-lwc git:(main) ✗ sf project deploy start --metadata-dir col-line-err
Deploying <version specified in manifest> metadata to [email protected] using the v58.0 SOAP API.
Deploy ID: 0Af8N00000tvZrkSAE
Status: Failed | ████████████████████████████████████████ | 2/2 Components (Errors:2) | 0/0 Tests (Errors:0)

Component Failures [2]
===============================================================
| Type  Name             Problem                    Line:Column
| ───── ──────────────── ────────────────────────── ───────────
| Error GeocodingService Unexpected token 'static'. 2:12
| Error GeocodingService Unexpected token 'static'. 2:12

✅ json output

{
  "status": 1,
  "result": {
    "checkOnly": false,
    "completedDate": "2023-10-09T14:36:37.000Z",
    "createdBy": "0058N000004sBPj",
    "createdByName": "User User",
    "createdDate": "2023-10-09T14:36:35.000Z",
    "details": {
      "componentFailures": [
        {
          "changed": false,
          "columnNumber": 12,
          "componentType": "ApexClass",
          "created": false,
          "createdDate": "2023-10-09T14:36:36.000Z",
          "deleted": false,
          "fileName": "zip/classes/GeocodingService.cls",
          "fullName": "GeocodingService",
          "lineNumber": 2,
          "problem": "Unexpected token 'static'.",
          "problemType": "Error",
          "success": false
        },
        {
          "changed": false,
          "columnNumber": 12,
          "componentType": "ApexClass",
          "created": false,
          "createdDate": "2023-10-09T14:36:36.000Z",
          "deleted": false,
          "fileName": "zip/classes/GeocodingService.cls",
          "fullName": "GeocodingService",
          "lineNumber": 2,
          "problem": "Unexpected token 'static'.",
          "problemType": "Error",
          "success": false
        }
      ],
      "componentSuccesses": [
        {
          "changed": true,
          "componentType": "",
          "created": false,
          "createdDate": "2023-10-09T14:36:37.000Z",
          "deleted": false,
          "fileName": "zip/package.xml",
          "fullName": "package.xml",
          "success": true
        }
      ],
      "runTestResult": {
        "numFailures": 0,
        "numTestsRun": 0,
        "totalTime": 0,
        "codeCoverage": [],
        "codeCoverageWarnings": [],
        "failures": [],
        "flowCoverage": [],
        "flowCoverageWarnings": [],
        "successes": []
      }
    },
    "done": true,
    "id": "0Af8N00000tvYRWSA2",
    "ignoreWarnings": false,
    "lastModifiedDate": "2023-10-09T14:36:37.000Z",
    "numberComponentErrors": 2,
    "numberComponentsDeployed": 0,
    "numberComponentsTotal": 2,
    "numberTestErrors": 0,
    "numberTestsCompleted": 0,
    "numberTestsTotal": 0,
    "rollbackOnError": true,
    "runTestsEnabled": false,
    "startDate": "2023-10-09T14:36:36.000Z",
    "status": "Failed",
    "success": false,
    "files": [
      {
        "error": "Unexpected token 'static'.",
        "problemType": "Error",
        "columnNumber": 12,
        "lineNumber": 2,
        "fullName": "GeocodingService",
        "type": "ApexClass",
        "state": "Failed",
        "filePath": "classes/GeocodingService.cls"
      },
      {
        "error": "Unexpected token 'static'.",
        "problemType": "Error",
        "columnNumber": 12,
        "lineNumber": 2,
        "fullName": "GeocodingService",
        "type": "ApexClass",
        "state": "Failed",
        "filePath": "classes/GeocodingService.cls"
      }
    ]
  },
  "warnings": []
}

❓ why do we see 2 component failures for 1 apex class? is this something we can fix in SDR or is just the MD API response?

[mshanemc]

❓ why do we see 2 component failures for 1 apex class? is this something we can fix in SDR or is just the MD API response?

I think they came back like that. But we could definitely de-dupe them

[cristiand391]

I think they came back like that. But we could definitely de-dupe them

Logged W-14262002 to track this 👍🏼