feat: col, line numbers on mdapi deploy errors (#771)

* feat: col, line numbers on mdapi deploy errors * fix: bump SDR --------- Co-authored-by: Cristian Dominguez <[email protected]>
salesforcecli · Oct 9, 2023 · dd27b0d · dd27b0d
1 parent bf28e05
commit dd27b0d
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 29 deletions.
diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
     "@salesforce/core": "^5.3.5",
     "@salesforce/kit": "^3.0.9",
     "@salesforce/sf-plugins-core": "^3.1.22",
-    "@salesforce/source-deploy-retrieve": "^9.7.15",
+    "@salesforce/source-deploy-retrieve": "^9.7.24",
     "@salesforce/source-tracking": "^4.2.16",
     "chalk": "^4.1.2",
     "shelljs": "^0.8.5",

diff --git a/src/formatters/deployResultFormatter.ts b/src/formatters/deployResultFormatter.ts
@@ -8,9 +8,9 @@ import * as path from 'path';
 import { EOL } from 'node:os';
 import * as fs from 'fs';
 import { ux } from '@oclif/core';
-import { DeployResult, FileResponse, FileResponseFailure, RequestStatus } from '@salesforce/source-deploy-retrieve';
+import { DeployResult, FileResponse, RequestStatus } from '@salesforce/source-deploy-retrieve';
 import { Org, SfError, Lifecycle } from '@salesforce/core';
-import { Duration, ensureArray } from '@salesforce/kit';
+import { Duration, ensureArray, sortBy } from '@salesforce/kit';
 import {
   CodeCoverageResult,
   CoverageReporter,
@@ -264,28 +264,23 @@ export class DeployResultFormatter extends TestResultsFormatter implements Forma
     if (this.result.response.status === RequestStatus.Succeeded) return;
 
     const failures = this.relativeFiles.filter(isSdrFailure);
-    // .push returns a number, so push here
-    failures.push(
-      ...ensureArray(this.result.response.details.componentFailures).map(
-        (fail) =>
-          ({
-            problemType: fail.problemType,
-            fullName: fail.fullName,
-            error: fail.problem,
-          } as FileResponseFailure)
-      )
-    );
     if (!failures.length) return;
 
     const columns = {
       problemType: { header: 'Type' },
       fullName: { header: 'Name' },
       error: { header: 'Problem' },
+      loc: { header: 'Line:Column' },
     };
     const options = { title: error(`Component Failures [${failures.length}]`), 'no-truncate': true };
     ux.log();
     ux.table(
-      failures.map((f) => ({ problemType: f.problemType, fullName: f.fullName, error: f.error })),
+      sortBy(failures, ['problemType', 'fullName', 'lineNumber', 'columnNumber', 'error']).map((f) => ({
+        problemType: f.problemType,
+        fullName: f.fullName,
+        error: f.error,
+        loc: f.lineNumber ? `${f.lineNumber}:${f.columnNumber}` : '',
+      })),
       columns,
       options
     );

diff --git a/test/utils/output.test.ts b/test/utils/output.test.ts
@@ -34,11 +34,7 @@ describe('deployResultFormatter', () => {
         {
           error: 'This component has some problems',
           fullName: 'ProductController',
-          problemType: 'Error',
-        },
-        {
-          error: 'This component has some problems',
-          fullName: 'ProductController',
+          loc: '27:18',
           problemType: 'Error',
         },
       ]);

diff --git a/yarn.lock b/yarn.lock
@@ -1121,16 +1121,16 @@
     chalk "^4"
     inquirer "^8.2.5"
 
-"@salesforce/source-deploy-retrieve@^9.7.15", "@salesforce/source-deploy-retrieve@^9.7.2", "@salesforce/source-deploy-retrieve@^9.7.20":
-  version "9.7.21"
-  resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-9.7.21.tgz#9d1b65ce0d50080a6886d04779049127ee7f37b9"
-  integrity sha512-MJvaDLzPUVpizdNGQ4ufwkmX8ogcQ0E1WkoTaPE0yionJgmIR78035TtJgnkuj+SDhHWhX1ABKbrkxzLn7obMg==
+"@salesforce/source-deploy-retrieve@^9.7.2", "@salesforce/source-deploy-retrieve@^9.7.20", "@salesforce/source-deploy-retrieve@^9.7.24":
+  version "9.7.24"
+  resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-9.7.24.tgz#6a200b830311b0db08a86026ece98c734d56f8c2"
+  integrity sha512-nkP9KgzuCoV6LtdDxgxt7KRnoQ6ZS12DJgXErCBXm7Swmr0dnbo1LhxrH05C4UFFe0JuvSta+u+Oor8jxSGaCQ==
   dependencies:
     "@salesforce/core" "^5.3.1"
     "@salesforce/kit" "^3.0.11"
     "@salesforce/ts-types" "^2.0.7"
     fast-levenshtein "^3.0.0"
-    fast-xml-parser "^4.2.7"
+    fast-xml-parser "^4.3.2"
     got "^11.8.6"
     graceful-fs "^4.2.11"
     ignore "^5.2.4"
@@ -3590,10 +3590,10 @@ fast-safe-stringify@^2.1.1:
   resolved "https://registry.yarnpkg.com/fast-safe-stringify/-/fast-safe-stringify-2.1.1.tgz#c406a83b6e70d9e35ce3b30a81141df30aeba884"
   integrity sha512-W+KJc2dmILlPplD/H4K9l9LcAHAfPtP6BY84uVLXQ6Evcz9Lcg33Y2z1IVblT6xdY54PXYVHEv+0Wpq8Io6zkA==
 
-fast-xml-parser@^4.2.5, fast-xml-parser@^4.2.7:
-  version "4.2.7"
-  resolved "https://registry.yarnpkg.com/fast-xml-parser/-/fast-xml-parser-4.2.7.tgz#871f2ca299dc4334b29f8da3658c164e68395167"
-  integrity sha512-J8r6BriSLO1uj2miOk1NW0YVm8AGOOu3Si2HQp/cSmo6EA4m3fcwu2WKjJ4RK9wMLBtg69y1kS8baDiQBR41Ig==
+fast-xml-parser@^4.2.5, fast-xml-parser@^4.3.2:
+  version "4.3.2"
+  resolved "https://registry.yarnpkg.com/fast-xml-parser/-/fast-xml-parser-4.3.2.tgz#761e641260706d6e13251c4ef8e3f5694d4b0d79"
+  integrity sha512-rmrXUXwbJedoXkStenj1kkljNF7ugn5ZjR9FJcwmCfcCbtOMDghPajbc+Tck6vE6F5XsDmx+Pr2le9fw8+pXBg==
   dependencies:
     strnum "^1.0.5"