Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass data-portal-for attr to list in portal #801

Merged
merged 3 commits into from
May 16, 2024
Merged

Pass data-portal-for attr to list in portal #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3da134
add data id to portal
Cloud11PL May 14, 2024
364e149
changesets
Cloud11PL May 14, 2024
4da1ecb
pass id to dynamic combobox attr
Cloud11PL May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-brooms-travel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@saleor/macaw-ui": patch
---

ID passed to comobobox will now be passed as an attribute to dropdown list wrapper box
1 change: 1 addition & 0 deletions src/components/Combobox/Dynamic/DynamicCombobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ const DynamicComboboxInner = <T extends Option>(
showEmptyState: hasNoOptions(children),
})}
className={listWrapperRecipe({ size })}
data-portal-for={id}
>
<List
as="ul"
Expand Down
1 change: 1 addition & 0 deletions src/components/Combobox/Static/Combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ const ComboboxInner = <T extends Option, V extends Option | string>(
showEmptyState: hasNoOptions(children),
})}
className={listWrapperRecipe({ size })}
data-portal-for={id}
>
<List
as="ul"
Expand Down
Loading