Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass data-portal-for attr to list in portal #801

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

Cloud11PL
Copy link
Member

I want to merge this change because it adds a data-portal-for={id} to combobox dropdown list box.

This PR closes #...

Screenshots

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • The storybook story is created and documentation is properly generated.
  • New component is wrapped in forwardRef.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:20am

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 4da1ecb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/macaw-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Cloud11PL Cloud11PL changed the title Pass id to portal boc Pass id to portal May 14, 2024
@Cloud11PL Cloud11PL added the release dev tag Release pkg to npm with @dev tag label May 14, 2024
@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels May 14, 2024
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240514115253.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels May 14, 2024
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240514122249.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL marked this pull request as ready for review May 16, 2024 10:33
@Cloud11PL Cloud11PL requested a review from a team as a code owner May 16, 2024 10:33
@Cloud11PL Cloud11PL requested review from Droniu and peelar and removed request for a team May 16, 2024 10:33
@Cloud11PL Cloud11PL changed the title Pass id to portal Pass data-portal-for attr to portal May 16, 2024
@Cloud11PL Cloud11PL changed the title Pass data-portal-for attr to portal Pass data-portal-for attr to list in portal May 16, 2024
@Cloud11PL Cloud11PL merged commit 65a8f3f into main May 16, 2024
9 checks passed
@Cloud11PL Cloud11PL deleted the add-data-for-combobox branch May 16, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release dev tag Release pkg to npm with @dev tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants