-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Parent in quotient rings too #37158
Draft
fchapoton
wants to merge
24
commits into
sagemath:develop
Choose a base branch
from
fchapoton:use_parent_for_quotient_rings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
use Parent in quotient rings too #37158
fchapoton
wants to merge
24
commits into
sagemath:develop
from
fchapoton:use_parent_for_quotient_rings
+177
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 1, 2024
…Gens Let's try to get rid of the last direct inheritance to `ParentWithGens`. (not quite the last one, see sagemath#37158 ) There remains many indirect inheritance, mostly through `Ring`, `Algebra`, `CommutativeRing` and their subclasses. This is a step towards cleaning and simplifying the old coercion framework. The present changes is close to the heart of sage, so appropriate timings should be checked. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37156 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
fchapoton
force-pushed
the
use_parent_for_quotient_rings
branch
from
February 6, 2024 14:08
dd2dbd6
to
55226d6
Compare
strange:
is not in and also
|
and now we have that
and simplified problem is
seems to be a difference in Unital
|
issue instead of trac
Documentation preview for this PR (built with commit b95c863; changes) is ready! 🎉 |
I have now made a simple first step in #38375. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using the deprecated
ParentWithGens
📝 Checklist