using Parent in integer rings instead of ParentWithGens #37156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try to get rid of the last direct inheritance to
ParentWithGens
.(not quite the last one, see #37158 )
There remains many indirect inheritance, mostly through
Ring
,Algebra
,CommutativeRing
and their subclasses. This is a step towards cleaning and simplifying the old coercion framework.The present changes is close to the heart of sage, so appropriate timings should be checked.
📝 Checklist