Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flaky tests #831

Merged
merged 3 commits into from
May 29, 2024
Merged

fix: Flaky tests #831

merged 3 commits into from
May 29, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented May 28, 2024 •
edited
Loading

What it solves

Resolves #827

How this PR resolves it

  • The api-kit test was failing because it was relying on the length of the results array instead of using the count property value. From 100 items, the call is automatically paginated, so count should always be used for these types of comparisons

  • A cache has been added in the Safe4337Pack instantiation, as the protocol-kit initialization takes time, and most of the instances can be reused

  • The timeout has been increased

@yagopv yagopv linked an issue May 28, 2024 that may be closed by this pull request
Check failing tests taking longer to finish #827
Closed
@coveralls
Copy link

coveralls commented May 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9271294912

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 77.907%
Totals Coverage Status
Change from base Build 9265754477: 0.1%
Covered Lines: 736
Relevant Lines: 880
💛 - Coveralls

@yagopv yagopv marked this pull request as ready for review May 29, 2024 09:15
@yagopv yagopv merged commit cac2a2f into development May 29, 2024
20 checks passed
@yagopv yagopv deleted the fix/flaky-tests branch May 29, 2024 11:06
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

@leonardotc leonardotc Awaiting requested review from leonardotc

@tmjssz tmjssz Awaiting requested review from tmjssz

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check failing tests taking longer to finish
3 participants
@yagopv @coveralls @dasanra