Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check failing tests taking longer to finish #827

Closed
dasanra opened this issue May 27, 2024 · 0 comments · Fixed by #831
Closed

Check failing tests taking longer to finish #827

dasanra opened this issue May 27, 2024 · 0 comments · Fixed by #831
Assignees
@yagopv
Labels
bug Something isn't working

Comments

@dasanra
Copy link
Collaborator

dasanra commented May 27, 2024

Context / issue

Some of the latest tests, 4337 related, are randomly failing. They are taking longer than expected when using the CI

Proposed solution

Check where the tests are hanging and improve the flow so they are stable.
Some of the tests is also having a wrong return value, so it may be that the testing Safe was modified at some moment.
@dasanra dasanra added the bug Something isn't working label May 27, 2024
@yagopv yagopv self-assigned this May 27, 2024
@yagopv yagopv mentioned this issue May 28, 2024
Merged
@yagopv yagopv linked a pull request May 28, 2024 that will close this issue
fix: Flaky tests #831
Merged
@dasanra dasanra closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopv yagopv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Flaky tests safe-global/safe-core-sdk
2 participants
@yagopv @dasanra