-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (interactive) background correction #197
Conversation
Otherwise, the webserver complains about the request for tile specs being too large
Reassigning @trautmane to have this merged as soon as possible. All of this is new code, so I'm not worried about compatibility issues. Comments about organization into packages, spark parallelization, and usage are highly welcome! Once this is merged and deployed, we can look at an example stack to see if the dynamic shading correction filter works as intended (it does in static renders). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just made a few minor comments/suggestions.
This PR adds tools for correcting global shading on large FIBSEM volumes (e.g., here). These tools are:
For supplying model parameters to the spark client, I used an ad hoc json representation, since the model is expected to vary in z. This representation is documented in
BackgroundCorrectionClient
. Feedback about the documentation and the representation itself is very welcome.One particular problem with doing this at the level of a stack is that we would need an exported mask to not also correct regions where there is no tissue. Is it safe to assume that a mask will always be exported when background correction is done? In this case, I will add support for masks.