-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatfield visualization and application #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ef55898. The filter is not used since this should not be done dynamically.
trautmane
reviewed
Apr 25, 2024
...s-java-client/src/main/java/org/janelia/render/client/MultiSemFlatFieldCorrectionClient.java
Show resolved
Hide resolved
...s-java-client/src/main/java/org/janelia/render/client/MultiSemFlatFieldCorrectionClient.java
Show resolved
Hide resolved
...s-java-client/src/main/java/org/janelia/render/client/MultiSemFlatFieldCorrectionClient.java
Outdated
Show resolved
Hide resolved
...s-java-client/src/main/java/org/janelia/render/client/MultiSemFlatFieldCorrectionClient.java
Outdated
Show resolved
Hide resolved
...s-java-client/src/main/java/org/janelia/render/client/MultiSemFlatFieldCorrectionClient.java
Show resolved
Hide resolved
...s-java-client/src/main/java/org/janelia/render/client/MultiSemFlatFieldCorrectionClient.java
Outdated
Show resolved
Hide resolved
This reverts commit c1284f8. The extracted substring is not only the sfov number but also includes the scan and mfov numbers
trautmane
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some code to visualize flat field estimates and apply them to the wafer_53 images.
There are two new clients:
FlatfieldVisualizationClient
creates a stack that shows all flat field estimates on a regular hexagonal grid (there is one flat field estimate per z-layer and per sfov, making one mfov column in total);MultiSemFlatFieldCorrectionClient
re-saves all source images of a collection of stacks and creates new stacks that point to the re-saved images.For now, the flat field estimates are created externally, but the plan is to port this to render at a later time.