Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: MFOV layer-prealign #184

Merged
merged 12 commits into from
Apr 27, 2024
Merged

Conversation

minnerbe
Copy link
Collaborator

@minnerbe minnerbe commented Mar 30, 2024

I tentatively added a pre-alignment routine that treats a single layer of a single MFOV as a tile and aligns these using a rigid model.

I tested this on a small stack (see MultiSemPreAlignClientTest). So far, it seems like pulling and processing all the data is fine (and does reduce the error by some factor), but pushing the data to the render database again doesn't seem to work. In particular, the put request that should set the stack state to complete doesn't return. Do you have any clues as to why this might be, @trautmane?

Once these issues are resolved, I would test this on a larger stack and also check if this reduces the time for the subsequent alignment. Finally, I'll make this into a spark client that can process multiple stacks at once.

Side note: To put the transforms computed by this method into the TileSpecs, I wanted to use SolveTools.getTransformSpec, but the TODOs there seem to indicate that this method doesn't work right now. The last commit that changed this method says that the issue is fixed, though. Can you please comment on that, @StephanPreibisch? Resolved by 0df486.

@minnerbe minnerbe marked this pull request as ready for review April 3, 2024 16:21
@minnerbe minnerbe requested a review from trautmane April 3, 2024 16:21
@minnerbe
Copy link
Collaborator Author

minnerbe commented Apr 3, 2024

I tested this pre-align method on this stack and got these results.

Copy link
Collaborator

@trautmane trautmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is about pulling all tile and match data for each stack in a single request. Let's discuss other options.

@trautmane trautmane merged commit b120b15 into newsolver Apr 27, 2024
2 checks passed
@trautmane trautmane deleted the feature/mFovLayer-prealign branch April 27, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants