-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: MFOV layer-prealign #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested this pre-align method on this stack and got these results. |
trautmane
reviewed
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is about pulling all tile and match data for each stack in a single request. Let's discuss other options.
render-ws-java-client/src/main/java/org/janelia/render/client/MultiSemPreAlignClient.java
Outdated
Show resolved
Hide resolved
render-ws-java-client/src/main/java/org/janelia/render/client/MultiSemPreAlignClient.java
Show resolved
Hide resolved
render-ws-java-client/src/main/java/org/janelia/render/client/MultiSemPreAlignClient.java
Show resolved
Hide resolved
...ent/src/main/java/org/janelia/render/client/newsolver/solvers/affine/MultiSemPreAligner.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tentatively added a pre-alignment routine that treats a single layer of a single MFOV as a tile and aligns these using a rigid model.
I tested this on a small stack (see
MultiSemPreAlignClientTest
). So far, it seems like pulling and processing all the data is fine (and does reduce the error by some factor), but pushing the data to the render database again doesn't seem to work. In particular, the put request that should set the stack state to complete doesn't return. Do you have any clues as to why this might be, @trautmane?Once these issues are resolved, I would test this on a larger stack and also check if this reduces the time for the subsequent alignment. Finally, I'll make this into a spark client that can process multiple stacks at once.
Side note: To put the transforms computed by this method into theResolved by 0df486.TileSpecs
, I wanted to useSolveTools.getTransformSpec
, but the TODOs there seem to indicate that this method doesn't work right now. The last commit that changed this method says that the issue is fixed, though. Can you please comment on that, @StephanPreibisch?