Performance tests #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! There are a bunch of changes to the abstract test class in this PR that are unrelated to the performance test and will have downstream effects on other n5 projects (n5-aws-s3, n5-blosc, n5-google-cloud, n5-jpeg, ...?). Should we do this in a separate PR and do in synchrony with the other projects? |
|
Absolutely can pull those out when I get a few cycles later tonight/tomorrow. |
|
Force pushed away changes to test case base class and opened a new PR #71 for that implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
If required the performance test can be easily excluded with the surefire plugin:
mvn test -D'test=!N5BenchmarkTest'If desired it could also be excluded by default.
While making these changes I noticed that the license on test files is GPLv2. @axtimwalde, was this just an oversight?