Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: skip file exists for getAttributes #125

Merged
merged 1 commit into from
Jul 15, 2024
Merged

perf: skip file exists for getAttributes #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/org/janelia/saalfeldlab/n5/GsonKeyValueN5Reader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,10 @@ default JsonElement getAttributes(final String pathName) throws N5Exception {
final String groupPath = N5URI.normalizeGroupPath(pathName);
final String attributesPath = absoluteAttributesPath(groupPath);

if (!getKeyValueAccess().isFile(attributesPath))
return null;

try (final LockedChannel lockedChannel = getKeyValueAccess().lockForReading(attributesPath)) {
return GsonUtils.readAttributes(lockedChannel.newReader(), getGson());
} catch (final N5Exception.N5NoSuchKeyException e) {
return null;
} catch (final IOException | UncheckedIOException e) {
throw new N5IOException("Failed to read attributes from dataset " + pathName, e);
}
Expand Down
Loading