Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't enforce serializeNulls, but DO still ensure null is still #42

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

cmhulbert
Copy link
Contributor

serialized regardless of serializeNulls for Raw compression

cmhulbert added 4 commits June 6, 2024 11:52
serialized regardless of `serializeNulls` for Raw compression
- added a serializer for ZArrayAttributes
- writeZArray via ZArrayAttributes object, not JsonElement
- expected compression can be `JsonNull` OR `null` depending on whether `serializeNull` or not

test: `serializeNulls` not set by default, so no `null` value here, therefore it doesn't parse as `JsonNull` but instead just returns `null`
…e versions

This is because when reading from the container with no cache, you get `null` but when writing/reading with the cache, the value is `JsonNull`.
@bogovicj bogovicj merged commit b26a8e8 into saalfeldlab:master Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants