Fix/compressor #37
Merged
Fix/compressor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cmhulbert
commented
Feb 21, 2024
•
cmhulbert
commented
- fix a compressor serialization bug
- add protected constructor to ZarrKeyValueReader to bypass root group exists check
- refactor N5ZarrTest to support multiple backend testing in n5-universe [WIP]
When registering the ZarCompressor#Raw RawCompression with Gson via the HierarchyTypeAdapter, it would have two JsonSerializers for with id `"raw"`. The correct one was only being used based on order of the class loader finding the annotation. For this test, it would always load the `ZarrCompressor#Raw` variant first (which was the wrong one, as it resulted in an empty JsonObject, due to reflection) and the override it in he TypeAdapter map with the N5 RawCompression variant (which is the right one). To ensure it doesn't rely on the order of the serializer, ZarrCompressor#Raw no longer extends RawCompression, and there is an explicit TypeAdapter for it now which Serializes to JsonNull.
This check was previously only in N5ZarrReader, but ideally those should be deprecated, so the logic should also belong in the ZarrKeyValueReader
…st class can be reused with different backends
* fixed zarr-python compatibility test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.