Skip to content

Commit

Permalink
Merge pull request #44 from saalfeldlab/cmhulbert-perf/skipIsFile
Browse files Browse the repository at this point in the history
Perf: skip isFile
  • Loading branch information
bogovicj authored Jul 16, 2024
2 parents b26a8e8 + 720d5f6 commit 8a404d8
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 6 deletions.
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>org.scijava</groupId>
<artifactId>pom-scijava</artifactId>
<version>37.0.0</version>
<version>38.0.1</version>
<relativePath />
</parent>

Expand Down Expand Up @@ -111,7 +111,7 @@
<scm>
<connection>scm:git:git://github.com/saalfeldlab/n5-zarr</connection>
<developerConnection>scm:git:[email protected]:saalfeldlab/n5-zarr</developerConnection>
<tag>HEAD</tag>
<tag>n5-zarr-1.3.4</tag>
<url>https://github.com/saalfeldlab/n5-zarr</url>
</scm>
<issueManagement>
Expand All @@ -138,7 +138,7 @@

<json-simple.version>1.1.1</json-simple.version>

<n5.version>3.2.0</n5.version>
<n5.version>3.3.0</n5.version>
<n5-zstandard.version>1.0.2</n5-zstandard.version>

</properties>
Expand Down
28 changes: 28 additions & 0 deletions release.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#release configuration
#Wed Jun 05 09:56:44 EDT 2024
scm.commentPrefix=[maven-release-plugin]
exec.pomFileName=pom.xml
pushChanges=false
releaseStrategyId=default
project.scm.org.janelia.saalfeldlab\:n5-zarr.developerConnection=scm\:git\:[email protected]\:saalfeldlab/n5-zarr
project.scm.org.janelia.saalfeldlab\:n5-zarr.tag=HEAD
project.dev.org.janelia.saalfeldlab\:n5-zarr=1.3.5-SNAPSHOT
projectVersionPolicyConfig=<projectVersionPolicyConfig>${projectVersionPolicyConfig}</projectVersionPolicyConfig>\n
scm.tag=n5-zarr-1.3.4
remoteTagging=true
exec.additionalArguments=-Dgpg.skip\=true
scm.branchCommitComment=@{prefix} prepare branch @{releaseLabel}
projectVersionPolicyId=default
project.scm.org.janelia.saalfeldlab\:n5-zarr.url=https\://github.com/saalfeldlab/n5-zarr
scm.url=scm\:git\:https\://github.com/saalfeldlab/n5-zarr
scm.tagNameFormat=@{project.artifactId}-@{project.version}
pinExternals=false
preparationGoals=clean verify
project.scm.org.janelia.saalfeldlab\:n5-zarr.connection=scm\:git\:git\://github.com/saalfeldlab/n5-zarr
scm.releaseCommitComment=@{prefix} prepare release @{releaseLabel}
exec.snapshotReleasePluginAllowed=false
exec.activateProfiles=deploy-to-scijava
project.rel.org.janelia.saalfeldlab\:n5-zarr=1.3.4
scm.developmentCommitComment=@{prefix} prepare for next development iteration
scm.rollbackCommitComment=@{prefix} rollback the release of @{releaseLabel}
completedPhase=end-release
Original file line number Diff line number Diff line change
Expand Up @@ -651,11 +651,10 @@ public DataBlock<?> readBlock(
zarrDatasetAttributes.getDimensionSeparator(),
zarrDatasetAttributes.isRowMajor()));

if (!keyValueAccess.isFile(absolutePath))
return null;

try (final LockedChannel lockedChannel = keyValueAccess.lockForReading(absolutePath)) {
return readBlock(lockedChannel.newInputStream(), zarrDatasetAttributes, gridPosition);
} catch (final N5Exception.N5NoSuchKeyException e) {
return null;
} catch (final Throwable e) {
throw new N5IOException(
"Failed to read block " + Arrays.toString(gridPosition) + " from dataset " + pathName,
Expand Down

0 comments on commit 8a404d8

Please sign in to comment.