Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android test action and fix outstanding CI issues #72

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

complexspaces
Copy link
Collaborator

@complexspaces complexspaces commented Mar 12, 2024

This PR performs some maintenance on our Android testing infrastructure. Notably it:

  1. Updates our Android runner action to try and pick up on bugfixes.
  2. Switches the job to run on Linux instead for speed. We enable KVM on the runner as well since the Android emulator needs virtualization and that needs to be fast.
  3. Moves the Android job into its own YAML area so it doesn't get confused with the host OS's tests anymore.
  4. Fixes the log output and artifact upload locations

Relates to #68

@complexspaces
Copy link
Collaborator Author

This PR is ready to go. We are now properly writing device/test logs to stdout and uploading the correct log output path:

image

@complexspaces complexspaces changed the title Update Android test action and use Linux runners instead Update Android test action and fix outstanding CI issues Mar 12, 2024
@complexspaces complexspaces force-pushed the update-android-testing branch 2 times, most recently from b9bdb4b to 3cd1134 Compare March 12, 2024 02:19
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this out! It'll be a really nice quality of life improvement.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@complexspaces complexspaces force-pushed the update-android-testing branch from 3cd1134 to 44db639 Compare March 12, 2024 16:15
@complexspaces complexspaces merged commit d68c2ed into main Mar 12, 2024
15 checks passed
@complexspaces complexspaces deleted the update-android-testing branch March 12, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants