tests: refresh LE real world verification test case, more logging #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `real_world_test` macro only included the test case's expected result in its log output. This makes it tricky to differentiate between failures for testcases that share the same expected result (e.g. `Ok(())`). This commit updates the macro so the generated test fn includes the reference subject identifier name as well as the expected result.
* Updates the test cert for presently unknown reasons the previous EE cert is returning an error in the Android real world verification test suite that appears resolved by refreshing the EE cert. * Updates the mock verification timestamp to be newer than the LE EE cert's NotBefore date.
💚 ✔️ |
Merged
|
This seems good to me, but I want to quickly try getting #72 working so we have these logs again first. |
complexspaces
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #68 updating the end-entity certificate used in the Let's Encrypt real world verification integration test suite seems to fix the CI failure in the Android tasks that creeped into
main~2 weeks ago.There are remaining mysteries to address, but this should be enough to fix CI while we dig deeper.