rename to_arc to clone_arc #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests are failing with possibly a crates.io outage: Status is 🍏 though. Will try again shortly. |
cpu
requested changes
Nov 16, 2023
to_arc converts a `*const C` into an `Option<Arc<T>>`. It had a lot of verbiage to explain what it was doing with reference counts. I think the conceptual model becomes a lot simpler if we rename the function to reflect what it is really doing: cloning the arc.
cpu
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_arc converts a
*const Cinto anOption<Arc<T>>. It had a lot of verbiage to explain what it was doing with reference counts. I think the conceptual model becomes a lot simpler if we rename the function to reflect what it is really doing: cloning the arc.