Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctor: Split version str with .lines() to account for Windows' \r\n #130

Merged
merged 1 commit into from
Aug 26, 2023
Merged

doctor: Split version str with .lines() to account for Windows' \r\n #130

merged 1 commit into from
Aug 26, 2023

Commits on Aug 26, 2023

  1. doctor: Split version str with .lines() to account for Windows' \r\n 

    On Windows at least `adb` prints it version string with carriage return;
leaving the `\r` in there (by only splitting on `\n`) and not trimming
the string causes us to print its version with a `\r` at the end,
clearing the whole line (i.e. it would print `adb     1.0.41\r` followed
by the path, and then only the path remains on this line).

Rust's `.lines()` implementation already takes care of this by splitting
(inclusively) on `\n` and trimming off that `\n` and _optionally also a
`\r`_ in the iterator before returning it to us.
    @MarijnS95
    MarijnS95 committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    05f23f9 View commit details
    Browse the repository at this point in the history