doctor: Split version str with .lines() to account for Windows' \r\n
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows at least `adb` prints it version string with carriage return; leaving the `\r` in there (by only splitting on `\n`) and not trimming the string causes us to print its version with a `\r` at the end, clearing the whole line (i.e. it would print `adb 1.0.41\r` followed by the path, and then only the path remains on this line). Rust's `.lines()` implementation already takes care of this by splitting (inclusively) on `\n` and trimming off that `\n` and _optionally also a `\r`_ in the iterator before returning it to us.
dvc94ch
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excerpt from #116 (comment)
On Windows at least
adbprints it version string with carriage return; leaving the\rin there (by only splitting on\n) and not trimming the string causes us to print its version with a\rat the end, clearing the whole line (i.e. it would printadb 1.0.41\rfollowed by the path, and then only the path remains on this line).Rust's
.lines()implementation already takes care of this by splitting (inclusively) on\nand trimming off that\nand optionally also a\rin the iterator before returning it to us.