Do not pass --parallel option to old cmake #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Ok, sorry but I've decided that I will no longer maintain this crate and it needs a new maintainer. |
1 similar comment
|
Ok, sorry but I've decided that I will no longer maintain this crate and it needs a new maintainer. |
m-ou-se
reviewed
May 11, 2022
|
Could we please get a new release with this fix included? Unfortunately, I just spent several hours on a goose chase with wondering why the cmake version check wasn't working because I thought this code was present in the most recent release when it actually wasn't! |
hishamhm
added a commit
to Kong/ngx_wasm_module
that referenced
this pull request
Aug 10, 2022
I haven't spotted this one before, but it just failed on me when testing the Ubuntu 18.04 build: The latest `cargo` uses `cmake --parallel` when building `wabt-sys` (which is required by `cwabt`, used by the V8 backend). The `--parallel` flag is only available from CMake 3.12 onwards, which is not included in the Ubuntu 18.04 distro. More info on the cmake version requirement for cmake-rs: rust-lang/cmake-rs#131 A fix was merged but a new version of the crate was not yet released: rust-lang/cmake-rs#146 Turns out the easiest way to get a binary for CMake >= 3.12 that's compatible with Ubuntu 18.04 is to install it via pip: ``` RUN apt-get install -y --no-install-recommends \ python3-pip \ python3-setuptools RUN pip3 install --upgrade pip RUN pip3 install scikit-build RUN pip3 install cmake ``` ...which worked, but pinning the dependency involved fewer moving parts and felt like a more stable solution.
hishamhm
added a commit
to Kong/ngx_wasm_module
that referenced
this pull request
Aug 10, 2022
The latest cargo uses cmake --parallel when building wabt-sys (which is required by cwabt, used by the V8 backend). The --parallel flag is only available from CMake 3.12 onwards, which is not included in the Ubuntu 18.04 distro. More info on the cmake version requirement for cmake-rs: rust-lang/cmake-rs#131 A fix was merged but a new version of the crate was not yet released: rust-lang/cmake-rs#146 Additionally, wabt-sys actually includes code which assumes CMake >= 3.12! See: https://ma.ttias.be/wabt-sys-compile-error-cmake-project-version-not-declared-in-scope-ubuntu-18-04/
hishamhm
added a commit
to Kong/ngx_wasm_module
that referenced
this pull request
Aug 11, 2022
The latest cargo uses cmake --parallel when building wabt-sys (which is required by cwabt, used by the V8 backend). The --parallel flag is only available from CMake 3.12 onwards, which is not included in the Ubuntu 18.04 distro. More info on the cmake version requirement for cmake-rs: rust-lang/cmake-rs#131 A fix was merged but a new version of the crate was not yet released: rust-lang/cmake-rs#146 Additionally, wabt-sys actually includes code which assumes CMake >= 3.12! See: https://ma.ttias.be/wabt-sys-compile-error-cmake-project-version-not-declared-in-scope-ubuntu-18-04/
hishamhm
added a commit
to Kong/ngx_wasm_module
that referenced
this pull request
Aug 12, 2022
The latest cargo uses cmake --parallel when building wabt-sys (which is required by cwabt, used by the V8 backend). The --parallel flag is only available from CMake 3.12 onwards, which is not included in the Ubuntu 18.04 distro. More info on the cmake version requirement for cmake-rs: rust-lang/cmake-rs#131 A fix was merged but a new version of the crate was not yet released: rust-lang/cmake-rs#146 Additionally, wabt-sys actually includes code which assumes CMake >= 3.12! See: https://ma.ttias.be/wabt-sys-compile-error-cmake-project-version-not-declared-in-scope-ubuntu-18-04/
Closed
emk
added a commit
to faradayio/geocode-csv
that referenced
this pull request
Oct 26, 2022
We also update to the latest `bigtable-rs` to fix the build. See also the following info on `cmake` and Ubuntu 18: rust-lang/cmake-rs#146 rust-lang/cmake-rs#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses the cmake version and avoids passing --parallel option to old cmake.
Fixes #131
Fixes #143
(I confirmed this fix works in a project where I actually ran into issue 131: openrr/openrr#584)