chore(runtime) fix cleanup of cwabt build #138
Conversation
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 35 35
Lines 5718 5718
=======================================
Hits 4965 4965
Misses 753 753
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Oh missed it too, merge whenever! |
|
Spotted another surprise while clean-building cwabt on Ubuntu 18.04... another commit incoming on this PR |
hishamhm
force-pushed
the
chore/fix-cwabt-clean
branch
from
16aa299 to
9149892
Compare
|
I tried pinning cmake-rs to an older version as suggested in rust-lang/cmake-rs#131 but then I got a different failure as described here, so I really ended up going with the way of installing a recent CMake binary on Ubuntu 18.04 via pip. |
The latest cargo uses cmake --parallel when building wabt-sys (which is required by cwabt, used by the V8 backend). The --parallel flag is only available from CMake 3.12 onwards, which is not included in the Ubuntu 18.04 distro. More info on the cmake version requirement for cmake-rs: rust-lang/cmake-rs#131 A fix was merged but a new version of the crate was not yet released: rust-lang/cmake-rs#146 Additionally, wabt-sys actually includes code which assumes CMake >= 3.12! See: https://ma.ttias.be/wabt-sys-compile-error-cmake-project-version-not-declared-in-scope-ubuntu-18-04/
hishamhm
force-pushed
the
chore/fix-cwabt-clean
branch
from
9149892 to
a59ce01
Compare
|
Should be good to go (I re-ran 18.04 after the latest force push just to check for typos) |
An oopsie left over from PR #137. Caught this right now while running a full
sudo ./util/release.sh --bin-all --v8 10.5.18 --ngx 1.23.1 testwith an emptywork/(ie, nothing previously cached). If therelease.ymlaction builds each package on its own clean environment that shouldn't affect it, but the leftover libcwabt built with archlinux did cause problems with centos7 when running--bin-allfrom the CLI.I'm still running it, so keeping this as Draft until a full run finishes (which includes building V8 5 times...) to see if anything else comes up.