feat(evm): expose account_mut on substate #98
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sorpaas, could you please take a look? This has been blocking us on the linked PR for a while and would love to get it over the line! |
|
Really sorry. I'll take a look at the linked PR today and see what could be done. |
|
@sorpaas thanks! We need to mutate an account's nonce. That can be done by exposing a mutable reference to it, as done in this PR. Otherwise, we'll need to add get/set nonce methods everywhere |
|
@sorpaas giving this one more bump... if there's no intention of merging pls let us know if possible so we consider alternative routes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sorpaas unfortunately #92 wasn't sufficient because we have our own
MemoryStackStateOwnedimplementation which owns the backend, so we do need to access the substate's method, instead of via theMemoryStackState. Would appreciate if we can get this merged with a quicker turnaround time, given our previous discussion